Skip to content

chore: use hermetic awk for mtree manipulation #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: use hermetic awk for mtree manipulation #647

wants to merge 2 commits into from
+32 −9

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Sep 25, 2025 •
edited
Loading

Testing locally isn't working on MacOS arm64:

ERROR: /private/var/tmp/_bazel_alexeagle/ac5c25dfb9cf2a4fcbea5ab9eb6f568e/external/gawk/BUILD.bazel:52:11: Linking external/gawk/libsupport.a [for tool] failed: (Exit 1): llvm-ar failed: error executing CppArchive command (from target @@gawk//:support) external/llvm_toolchain/bin/llvm-ar @bazel-out/darwin_arm64-opt-exec-ST-a828a81199fe/bin/external/gawk/libsupport.a-2.params

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
external/llvm_toolchain/bin/llvm-ar: error: only one operation may be specified
OVERVIEW: LLVM Archiver

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

e2e/use_release folder: LCOV of commit 437ba48 during CI #1989

Summary coverage rate:
  lines......: 100.0% (2 of 2 lines)
  functions..: 100.0% (1 of 1 function)
  branches...: no data found

Files changed coverage rate: n/a

UebelAndre
UebelAndre requested changes Sep 25, 2025
View reviewed changes
@alexeagle @UebelAndre
Update repositories.bzl
437ba48 
Co-authored-by: UebelAndre <[email protected]>
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Sep 25, 2025 •
edited
Loading

Test

7 test targets passed

Targets 
//py/tests/py_image_layer:my_app_layers_test_test [k8-fastbuild]                          44ms
//py/tests/py_image_layer:py_image_test [k8-fastbuild]                                    4s
//py/tests/py_venv_image_layer:my_app_amd64_layers_test [k8-fastbuild]                    100ms
//py/tests/py_venv_image_layer:my_app_arm64_layers_test [k8-fastbuild]                    48ms
//py/tests/py_venv_image_layer:py_amd64_image_command_test [k8-fastbuild]                 6s
//py/tests/py_venv_image_layer:py_amd64_image_content_test [k8-fastbuild]                 269ms
//py/tests/py_venv_image_layer:py_arm64_image_content_test [k8-fastbuild]                 2s

Total test execution time was 12s. 38 tests (84.4%) were fully cached saving 1m 14s.

UebelAndre
UebelAndre approved these changes Sep 25, 2025
View reviewed changes
Copy link

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look at the build issue separately but the changes otherwise seem fine to me 😄

arrdem
arrdem requested changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@arrdem arrdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we can sort out the test issues; not willing to break local dev for the rest of the ruleset on this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrdem arrdem arrdem requested changes

@thesayyn thesayyn thesayyn approved these changes

@UebelAndre UebelAndre UebelAndre approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeagle @arrdem @thesayyn @UebelAndre